Allow Specific rockstar license holders to join even if the duplicate license check is enabled#1154
Closed
farhannisar306 wants to merge 4 commits intoqbcore-framework:mainfrom
Closed
Allow Specific rockstar license holders to join even if the duplicate license check is enabled#1154farhannisar306 wants to merge 4 commits intoqbcore-framework:mainfrom
farhannisar306 wants to merge 4 commits intoqbcore-framework:mainfrom
Conversation
Implemented an "exceptional licenses" logic to let shared account players play
Added 2 sample licenses to be "exceptional"
Contributor
|
I think this PR is a little noise, if you could try to add early return to avoid that much indentation, it would be great. Thanks for trying to add to the QBCore framework btw!! Keep it up. |
|
This PR has had 60 days of inactivity & will close within 7 days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhanced duplicate license check functionality by allowing specific Rockstar license holders to bypass the check when enabled. Added support for configurable exceptional licenses in
QBConfig.Server.ExceptionalLicensesChecklist